Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42885 )
Change subject: soc/amd/picasso/memlayout: Verify bootblock is 16-bit aligned ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42885/1/src/soc/amd/picasso/memlayo... File src/soc/amd/picasso/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/42885/1/src/soc/amd/picasso/memlayo... PS1, Line 84: _ = ASSERT(CONFIG_BOOTBLOCK_ADDR == ((CONFIG_BOOTBLOCK_ADDR + 0xFFFF) & 0xFFFF0000), "Bootblock must be 16 bit aligned"); We should move this to src/cpu/x86/16bit/reset16.inc and mark it aligned to 16 bits.