build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 )
Change subject: cbfstool: add an option for creating a topswap bootblock
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/#/c/22537/6/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/#/c/22537/6/util/cbfstool/cbfstool.c@347
PS6, Line 347: char *new_data = (char*)malloc(bb_size);
"(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/22537/6/util/cbfstool/cbfstool.c@1643
PS6, Line 1643: switch (param.topswap_size){
switch and case should be at the same indent
https://review.coreboot.org/#/c/22537/6/util/cbfstool/cbfstool.c@1643
PS6, Line 1643: switch (param.topswap_size){
space required before the open brace '{'
--
To view, visit
https://review.coreboot.org/22537
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8
Gerrit-Change-Number: 22537
Gerrit-PatchSet: 6
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-Comment-Date: Tue, 29 May 2018 11:42:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No