Roy Mingi Park has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32434 )
Change subject: mb/google/sarien: Toggle SSD reset pin on DVT2
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32434/4/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/gpio.c:
https://review.coreboot.org/#/c/32434/4/src/mainboard/google/sarien/variants...
PS4, Line 227: /
extra /? was there before...
I noticed that '/' doesn't need. Lance, please clean it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie734875a49b8b61f8b813c473d30cbcaf4dd13d1
Gerrit-Change-Number: 32434
Gerrit-PatchSet: 4
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 24 Apr 2019 02:12:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment