Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30863 )
Change subject: cpu/intel/socket_FCBGA559: Use the non-evict cache as ram setup
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/30863/5/src/cpu/intel/car/non-evict/cache_as...
File src/cpu/intel/car/non-evict/cache_as_ram.S:
https://review.coreboot.org/#/c/30863/5/src/cpu/intel/car/non-evict/cache_as...
PS5, Line 85: movl $0x80000008, %eax
You need to check this MSR is always supported for the socket. The check in p4-netburst was more complete.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30863
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec943f5710314fb7a644d89dbd6d8c425f4ed735
Gerrit-Change-Number: 30863
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 12 Jan 2019 07:39:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment