Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34484 )
Change subject: mb/google/hatch: Initialize SSD GPIOs in bootblock ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34484/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34484/1//COMMIT_MSG@16 PS1, Line 16: Run faft_bios
Is the 0x5a issue resolved with this for Hatch?
Not completely resolved. But I do believe that these are required. I think that there are still other issues.
https://review.coreboot.org/c/coreboot/+/34484/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34484/1/src/mainboard/google/hatch/... PS1, Line 445: GPP_E4
Is this really required? It seems to be a wake pin?
I pulled the SSD pins over together, so I'm not sure if this one needs to be initialized in bootblock. I can take it out for now.
https://review.coreboot.org/c/coreboot/+/34484/1/src/mainboard/google/hatch/... PS1, Line 447: GPP_E5
Does this matter for NVMe? It seems to be a SATA related pin. […]
This fix is not specific for NVMes. Do you want me to separate the NVMe related GPIOs and the SATA specific ones? This was supposed to be relevant for all storage devices.