Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35730 )
Change subject: sb,nb/intel/fsp_rangeley: Rename from xx_DEV_FUNC
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35730/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35730/4//COMMIT_MSG@11
PS4, Line 11: renamed
Ah ok. The SA (system agent) is a proxy for north cluster and pch a proxy for south cluster. […]
Ack
https://review.coreboot.org/c/coreboot/+/35730/4/src/northbridge/intel/fsp_r...
File src/northbridge/intel/fsp_rangeley/fsp/chipset_fsp_util.c:
https://review.coreboot.org/c/coreboot/+/35730/4/src/northbridge/intel/fsp_r...
PS4, Line 112: UpdData->PcdEnableLan);
This code ties PCI device BDF hard to the functionality it provides. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35730
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ead2bc5e41a86c9aeef730f5664a30406414c8c
Gerrit-Change-Number: 35730
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Guckian
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 05 Oct 2019 04:57:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment