build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32152 )
Change subject: src/security/vboot: Changed the logic to verify a stage after it has been loaded into DRAM ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/32152/1/src/security/vboot/vboot_logic_ex.c File src/security/vboot/vboot_logic_ex.c:
https://review.coreboot.org/#/c/32152/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 253: if (!map) die("ERROR: Stage Mapping failed"); code indent should use tabs where possible
https://review.coreboot.org/#/c/32152/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 253: if (!map) die("ERROR: Stage Mapping failed"); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32152/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 253: if (!map) die("ERROR: Stage Mapping failed"); trailing statements should be on next line
https://review.coreboot.org/#/c/32152/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 286: rdev_munmap(rdev, map); code indent should use tabs where possible
https://review.coreboot.org/#/c/32152/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 286: rdev_munmap(rdev, map); please, no spaces at the start of a line
https://review.coreboot.org/#/c/32152/1/src/security/vboot/vboot_logic_ex.c@... PS1, Line 296: } else { please, no space before tabs