Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42947 )
Change subject: doc/mb/ocp: Add documentation for Delta Lake
......................................................................
Patch Set 3:
(4 comments)
Thanks!
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp...
File Documentation/mainboard/ocp/deltalake.md:
https://review.coreboot.org/c/coreboot/+/42947/1/Documentation/mainboard/ocp...
PS1, Line 17: jointly develop FSP/coreboot/Linuxboot solution on Delta Lake as a hack project.
I'd like a better word than hack. In fact, I would remove "as a hack project" words entirely.
Done
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp...
File Documentation/mainboard/ocp/deltalake.md:
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp...
PS2, Line 93: CooperLake
Cooper Lake
Done
https://review.coreboot.org/c/coreboot/+/42947/3/Documentation/mainboard/ocp...
File Documentation/mainboard/ocp/deltalake.md:
https://review.coreboot.org/c/coreboot/+/42947/3/Documentation/mainboard/ocp...
PS3, Line 11: one socket
single-socket
Done
https://review.coreboot.org/c/coreboot/+/42947/3/Documentation/mainboard/ocp...
PS3, Line 11: Sacalable
no a: Scalable
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9216c80023db071591c8d3add7c0f041e9e6b97e
Gerrit-Change-Number: 42947
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ron Minnich
rminnich@google.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 01 Jul 2020 23:04:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: ron minnich
rminnich@gmail.com
Gerrit-MessageType: comment