Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41600 )
Change subject: security/tpm: Use SPDX identifiers
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h
File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/41600/1/src/security/tpm/tss.h@3
PS1, Line 3: /*
: * TPM Lightweight Command Library.
: *
: * A low-level library for interfacing to TPM hardware or an emulator.
: */
From the style guide, I think the two preferred options are […]
^^ Indeed. Any chance you could update the files in this CL to use style #2 of the above? I think we just need an extra line break in a few spots...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41600
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22001320f2ce1f0db348e0f7fabc5a65b50ba53e
Gerrit-Change-Number: 41600
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 May 2020 03:49:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Jacob Garber
jgarber1@ualberta.ca
Gerrit-MessageType: comment