Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47591 )
Change subject: libpayload/keyboard: Add debug output to all state transitions ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47591/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/47591/1/payloads/libpayload/drivers... PS1, Line 253: STATE_IGNORE
Removed on purpose because this is supposed to be the last […]
NB. Maybe we should get rid of the IGNORE state. As we start the initialization automatically (and I wouldn't want to change that to keep the regression potential low), we end up in the IGNORE state when no keyboard is attached, hence breaking hot-plugging after 30s :-/ it would need more accurate timeout handling to fix that and keep an IGNORE state for incompatible keyboards (which might break, again, ThinkPads on a cold boot).