Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47653 )
Change subject: soc/intel/tigerlake: Define TCSS AUX pin bias control
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47653/1/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/47653/1/src/soc/intel/tigerlake/inc...
PS1, Line 103: 0x09000000
for the GPIO pins this is how FSP has them defined and what it is expecting. see FspsUpd. […]
I see, it's a chipset-specific constant, thanks Brandon!
Caveh, how about a `#define TGL_LP_GPIO_ID 0x09000000` instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47653
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I001aede139c2503ce9cae3af8d625624ff6e1af7
Gerrit-Change-Number: 47653
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 21:17:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment