Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33036 )
Change subject: sb/intel/common: Add a common interface to set final OPs settings ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
(3 comments)
There are probably better ways to handle non-default configurations. I remember some discussion, with Stefan I guess, that there are ways to derive the settings from descriptor information.
The thing with retrofitted ports is that you sometimes just don't know what flash chips the board may ship with (or the user may have soldered to it). So without any runtime detection of the chip, this won't always work.
Maybe just a list of SST flash that use AAI could do the trick?