Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31148 )
Change subject: google/kukui: Set GPIO_RESET to output mode
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31148/1/src/mainboard/google/kukui/chromeos....
File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/#/c/31148/1/src/mainboard/google/kukui/chromeos....
PS1, Line 27: GPIO_RESET
I do think about that when I add this setting. […]
Tristan is right, you don't really need it in lb_gpios.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31148
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd2c6c071871edc59497fbb245cdbec6a814f621
Gerrit-Change-Number: 31148
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Jan 2019 05:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tristan Hsieh
tristan.shieh@mediatek.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment