build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29959 )
Change subject: qcs405:Add SPI_RAM_SIMULATION support for QCS405 ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_contro... File src/soc/qualcomm/qcs405/flash_controller.c:
https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_contro... PS2, Line 37: static int ram_read(const struct spi_flash *flash, u32 addr, size_t len, void *buf) line over 80 characters
https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_contro... PS2, Line 68: { that open brace { should be on the previous line
https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_contro... PS2, Line 78: static char name[] = "ram_flash"; static char array declaration should probably be static const char
https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_contro... PS2, Line 80: printk(BIOS_INFO, "[%s]..CONFIG_QC_SOC_SIMULATE\n", __FUNCTION__); __func__ should be used instead of gcc specific __FUNCTION__
https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/flash_contro... PS2, Line 82: printk(BIOS_INFO, "[%s]..ram_flash\n", __FUNCTION__); __func__ should be used instead of gcc specific __FUNCTION__
https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/mmu.c File src/soc/qualcomm/qcs405/mmu.c:
https://review.coreboot.org/#/c/29959/2/src/soc/qualcomm/qcs405/mmu.c@40 PS2, Line 40: mmu_config_range((void *)0x80000000, 0x40000000, MA_MEM | MA_NS | MA_RW); line over 80 characters