View Change

6 comments:

• File src/soc/qualcomm/qcs405/flash_controller.c:

  • Patch Set #2, Line 37: static int ram_read(const struct spi_flash *flash, u32 addr, size_t len, void *buf)

    line over 80 characters

  • Patch Set #2, Line 68: {

    that open brace { should be on the previous line

  • Patch Set #2, Line 78: static char name[] = "ram_flash";

    static char array declaration should probably be static const char

  • Patch Set #2, Line 80: printk(BIOS_INFO, "[%s]..CONFIG_QC_SOC_SIMULATE\n", __FUNCTION__);

    __func__ should be used instead of gcc specific __FUNCTION__

  • Patch Set #2, Line 82: printk(BIOS_INFO, "[%s]..ram_flash\n", __FUNCTION__);

    __func__ should be used instead of gcc specific __FUNCTION__

• File src/soc/qualcomm/qcs405/mmu.c:

  • Patch Set #2, Line 40: mmu_config_range((void *)0x80000000, 0x40000000, MA_MEM | MA_NS | MA_RW);

    line over 80 characters

To view, visit change 29959. To unsubscribe, or for help writing mail filters, visit settings.