Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: soc/intel/skylake: Update GFX devtree options ......................................................................
Patch Set 8:
Patch Set 7: Code-Review-1
IMO, this patch does too much at once to keep track of everything...
Open questions:
- Why change the PrimaryDisplay setting of h110m?
- Why would we ever set `PrimaryDisplay = Display_Auto` together with `SkipExtGfxScan`?
- If I didn't miss it, the `SkipExtGfxScan` UPD wasn't set before? So this change changes all boards without mentioning it?
- What does `SkipExtGfxScan` do anyway?
3) "If I didn't miss it, the SkipExtGfxScan UPD wasn't set before? So this change changes all boards without mentioning it?" - This parameter would be defined in the devicetree.cb, but was not set to upd. In this case, the default upd value 0 is used for the option (Disable: Scan external display devices).
Now, if in dt.cb set SkipExtGfxScan=1, we set so that FSP doesn`t scan external gfx devices.
I will add this information to the commit message. (I move these changes to a separate patch Change-Id: Ie88a41bdf31f7c3e88df6c70c82a1cbf866372c4 )