Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42403 )
Change subject: mb/asrock/b85m_pro4: Properly select muxed functions ......................................................................
Patch Set 10: Code-Review+1
(1 comment)
would be nice to have selecting SUPERIO_NUVOTON_NCT6776_COM_A only modify the bits for the serial port mux, but this is out of scope of this patch.
https://review.coreboot.org/c/coreboot/+/42403/10/src/mainboard/asrock/b85m_... File src/mainboard/asrock/b85m_pro4/bootblock.c:
https://review.coreboot.org/c/coreboot/+/42403/10/src/mainboard/asrock/b85m_... PS10, Line 16: /* Select SIO pin states */ pin mux state? those registers should be about the pin muxing and not that much about the pin states