build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/#/c/31448/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/#/c/31448/1/src/device/pci_device.c@790 PS1, Line 790: if (!IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/31448/1/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/#/c/31448/1/src/device/pci_rom.c@188 PS1, Line 188: /* Set the start of shadow memory for this Integrated or Discrete VGA. */ line over 80 characters
https://review.coreboot.org/#/c/31448/1/src/device/pci_rom.c@190 PS1, Line 190: run_rom = (struct rom_header *)(uintptr_t)PCI_VGA_RAM_IMAGE_START; line over 80 characters
https://review.coreboot.org/#/c/31448/1/src/device/pci_rom.c@192 PS1, Line 192: if ((dev->class >> 8) == PCI_CLASS_DISPLAY_OTHER) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31448/1/src/device/pci_rom.c@193 PS1, Line 193: run_rom = (struct rom_header *)(uintptr_t)PCI_RAM_IMAGE_START; line over 80 characters
https://review.coreboot.org/#/c/31448/1/src/device/pci_rom.c@270 PS1, Line 270: if ((device->class >> 8) != PCI_CLASS_DISPLAY_VGA) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31448/1/src/device/pci_rom.c@275 PS1, Line 275: if ((device->class >> 8) == PCI_CLASS_DISPLAY_OTHER) { braces {} are not necessary for any arm of this statement