HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mainboard/lenovo/x230: Add ThinkPad x230s as a variant
......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41390/26/src/mainboard/lenovo/x230/...
File src/mainboard/lenovo/x230/variants/x230s/early_init.c:
https://review.coreboot.org/c/coreboot/+/41390/26/src/mainboard/lenovo/x230/...
PS26, Line 2:
: #include <bootblock_common.h>
: #include <northbridge/intel/sandybridge/sandybridge.h>
: #include <northbridge/intel/sandybridge/raminit_native.h>
: #include <southbridge/intel/bd82x6x/pch.h>
please include only what you use
Done
Thank you
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id59cdc5479aaf70809dd1ca613056263661455eb
Gerrit-Change-Number: 41390
Gerrit-PatchSet: 27
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 14 Jun 2020 09:00:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment