Attention is currently required from: ritul guru, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51674 )
Change subject: mb/amd/bilby: enable boot from NVMe SSD
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/amd/bilby/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/51674/comment/dbc1b780_a5ed9967
PS7, Line 22:
nit: remove this extra whitespace here
File src/mainboard/amd/bilby/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/51674/comment/4fad51a8_c786dcca
PS7, Line 73: const fsp_ddi_descriptor **ddi_descs, size_t *ddi_num)
I would leave lines 72 and 73 as-is and put the tabs back in. This looks odd having the statements below aligned with the functions arguments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4407f82122c04b13684d4176ba5cd5a9fe03f0db
Gerrit-Change-Number: 51674
Gerrit-PatchSet: 7
Gerrit-Owner: ritul guru
ritul.bits@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 07 Apr 2021 14:13:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment