Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32716 )
Change subject: vboot: Turn vboot_logic_executed() into a static inline ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32716/4/src/security/vboot/misc.h File src/security/vboot/misc.h:
https://review.coreboot.org/c/coreboot/+/32716/4/src/security/vboot/misc.h@1... PS4, Line 104: extern int vboot_executed;
-Wnested-externs won't like it
Do... we not like nested externs? I mean, all that warning does is point out constructs like this -- it doesn't check for mistakes or anything, it's just a style enforcer. I think this notation has good, valid uses (e.g. it allows this function to be a static inline while still preventing other code from accessing a global directly which should only be accessed through this helper function). I don't see why we should make the compiler ban it.