Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons.
Marvin Drees has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48648 )
Change subject: [WIP] mb/asus/sklkbl_h: Add base for Asus Skylake Boards
......................................................................
Patch Set 16:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48648/comment/1a870294_bf291142
PS16, Line 28: - EM100 usage flakey
It’d be great if you elaborated a little.
First I need to run "make" twice so the ifdtool actually modifies the values, second even if the image is modified to run at lower speeds sometimes it wouldn't start and the trace output of the em100 shows "unknown instruction" several times followed by "chip erase" several times. These issues can't reliably be reproduced though, they only happen every 1 out of 5 tries roughly, that's why I just called it flakey.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab30596f2a12931679687c9f56427712b65f9363
Gerrit-Change-Number: 48648
Gerrit-PatchSet: 16
Gerrit-Owner: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 18 Aug 2021 13:16:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment