John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31917 )
Change subject: soc/intel/cnl: Generate ACPI DMAR table ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31917/1/src/soc/intel/cannonlake/include/soc... File src/soc/intel/cannonlake/include/soc/systemagent.h:
https://review.coreboot.org/#/c/31917/1/src/soc/intel/cannonlake/include/soc... PS1, Line 36: 0x5da8 : #define GFXVTBAR 0x5400 : #define EDRAMBAR 0x5408 : #define IPUVTBAR 0x7884 : #define VTVC0BAR 0x5410 : #define REGBAR
maybe use tab ?
done