Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42842 )
Change subject: mb/amd/mandolin: factor out eMMC GPIO pin mux setup
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42842/1/src/mainboard/amd/mandolin/...
File src/mainboard/amd/mandolin/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42842/1/src/mainboard/amd/mandolin/...
PS1, Line 11: # CONFIG_PICASSO_LPC_IOMUX
I don't see such style rule being enforced anywhere. […]
if the endif statement is far way from the ifeq/ifneq one, it should definitely be there, but in this case those are very close together, so I don't think that it's necessary or really useful here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic49a668f82fbc1b851c07d312b543d2889fe4734
Gerrit-Change-Number: 42842
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 28 Jun 2020 14:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment