Attention is currently required from: Tzung-Bi Shih, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49135 )
Change subject: mb/google/asurada: Support audio
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49135/comment/1b7c15cb_c395ac62
PS1, Line 10:
this is coreboot upstream, IIUC, BUG= shouldn't require.
It's true this is coreboot upstream, but actually we usually also put BUG= here, and I think they don't mind 😊
Patchset:
PS2:
Do you have any dependency on other changes that are not merged yet?
If no, I'd recommend rebasing this to master head (not coreboot tot) so we can merge this earlier.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If595657bbddad85bc9a154b3648bae1190cb00b5
Gerrit-Change-Number: 49135
Gerrit-PatchSet: 2
Gerrit-Owner: Tzung-Bi Shih
tzungbi@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Tzung-Bi Shih
tzungbi@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 08 Jan 2021 04:50:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tzung-Bi Shih
tzungbi@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment