Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34752/2/src/arch/x86/c_start.S File src/arch/x86/c_start.S:
https://review.coreboot.org/c/coreboot/+/34752/2/src/arch/x86/c_start.S@42 PS2, Line 42: _start:
Would a weakly linked symbol to the beginning of exit_car. […]
incase we would like to tear down car in ranmstage then ramstage entry point will b exit_car.S rather being conventional c_start.S then avoiding multiple instances of _start for a single stage. Making it weak might also leads into same confusion?
https://review.coreboot.org/c/coreboot/+/34752/2/src/arch/x86/exit_car.S File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/34752/2/src/arch/x86/exit_car.S@48 PS2, Line 48: post_car_stack_top
The stackpointer is now moved twice. Not sure if that can cause issues.
no, it will be only once, either by postcar or by ramstage based on if postcar is present or not. it won't create overhead because purpose is just to tear down car before continuing