Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39325 )
Change subject: mb/google/dedede: Configure EC <-> AP GPIOs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39325/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39325/1/src/mainboard/google/dedede...
PS1, Line 372: PAD_CFG_GPI
Checking if this is the right config for Wake interrupt.
Leave it as NF1 - LAN_WAKE.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39325
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7
Gerrit-Change-Number: 39325
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Mar 2020 21:32:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment