Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78957?usp=email )
Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri ......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/geralt/panel_geralt.c:
https://review.coreboot.org/c/coreboot/+/78957/comment/9aba014d_61a790cd : PS10, Line 3: #include <boardid.h> : #include <console/console.h> : #include <delay.h> : #include <gpio.h> : #include <soc/gpio_common.h>
no longer needed ?
Build failed if remove <console/console.h>
``` In file included from src/soc/mediatek/mt8188/include/soc/i2c.h:11, from src/mainboard/google/geralt/panel_ciri.c:3: src/soc/mediatek/common/include/soc/i2c_common.h:23:42: error: expected ')' before numeric constant 23 | check_member(mt_i2c_dma_regs, dma_tx_len, 0x24); | ^~~~~ | ) CC ramstage/lib/boot_device.o CC ramstage/lib/bootmem.o cc1: note: unrecognized command-line option '-Wno-array-compare' may have been intended to silence earlier diagnostics ```