[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Add GPIOs layout for Lewisburg PCH

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35031 )

Change subject: soc/intel/skylake: Add GPIOs layout for Lewisburg PCH
......................................................................

Patch Set 13:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35031/12/src/soc/intel/skylake/acpi... 
File src/soc/intel/skylake/acpi/gpio.asl:

https://review.coreboot.org/c/coreboot/+/35031/12/src/soc/intel/skylake/acpi... 
PS12, Line 81: WELISBURG_SOC_PCH_H
> :D :D Oh, sorry Ж) Maybe I need a vacation :D […]

You don't need the _H, SKL have _LP and _H sku, it seems LBG don't have _LP version at all. I will suggest that can be LEWISBURG_PCH and that's it.

https://review.coreboot.org/c/coreboot/+/35031/12/src/soc/intel/skylake/incl... 
File src/soc/intel/skylake/include/soc/gpio_defs.h:

https://review.coreboot.org/c/coreboot/+/35031/12/src/soc/intel/skylake/incl... 
PS12, Line 24:
> What about the space here? I think it is also unnecessary

I don't think that's necessary.