Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38383 )
Change subject: intel/i440bx: Resolve long standing raminit TODOs ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/38383/1/src/northbridge/intel/i440b... File src/northbridge/intel/i440bx/raminit.c:
https://review.coreboot.org/c/coreboot/+/38383/1/src/northbridge/intel/i440b... PS1, Line 1030: /* Enable normal refresh with the NB. */
The second bit enables clock gating when it senses idle across the board. […]
Well, the commented-out line in line 1026 is the same as line 1031, which is what I was referring to. I don't think clock gating is worth the hassle for such an old platform.
In any case, done.
https://review.coreboot.org/c/coreboot/+/38383/2/src/northbridge/intel/i440b... File src/northbridge/intel/i440bx/raminit.c:
https://review.coreboot.org/c/coreboot/+/38383/2/src/northbridge/intel/i440b... PS2, Line 361: // TODO: Only do this later? There's a PMCR TODO here!