[coreboot-gerrit] Change in coreboot[master]: util/mb/google: Add spd_tools to generate SPDs for TGL boards

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41612 )

Change subject: util/mb/google: Add spd_tools to generate SPDs for TGL boards
......................................................................

Patch Set 4:

(2 comments)
> Patch Set 3:
>
> (18 comments)

Thanks for all the helpful comments, Ron. I will work on these and push a patchset.

https://review.coreboot.org/c/coreboot/+/41612/2/util/mainboard/google/spd_t... 
File util/mainboard/google/spd_tools/lp4x/gen_part_id.go:

https://review.coreboot.org/c/coreboot/+/41612/2/util/mainboard/google/spd_t... 
PS2, Line 5: import "encoding/csv"
> Go ahead and do this: […]

Done

https://review.coreboot.org/c/coreboot/+/41612/2/util/mainboard/google/spd_t... 
PS2, Line 25: var spdDirPtr = flag.String("spd_dir", "", "Directory containing SPD files and manifest")
> it's also common here […]

Done