[coreboot-gerrit] Change in coreboot[master]: cpu/x86/smm: Introduce SMM module loader version 2

[Rocky Phagura (Code Review)]

Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43684 )

Change subject: cpu/x86/smm: Introduce SMM module loader version 2
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43684/5/src/cpu/x86/mp_init.c 
File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/43684/5/src/cpu/x86/mp_init.c@782 
PS5, Line 782: cpus
> The original setting is the following: […]

In the original SMM loader, this is set to num_cpus. In my first patch of SMM version loader 2, I set this to 1. As we discussed, for platforms with less than 32 CPU threads, they can all relocate at the same time without problems.  So now I added an #if condition and if its loader version 2 and only then do we want to relocate each CPU one by one. So this helps with backward comptability. Let me know if you need more info on this. Here is a snippet from the original smm module loader.

struct smm_loader_params smm_params = {
    	.per_cpu_stack_size = CONFIG_SMM_STUB_STACK_SIZE,
    	.num_concurrent_stacks = num_cpus,
    	.per_cpu_save_state_size = save_state_size,
    	.num_concurrent_save_states = 1,
    	.handler = smm_do_relocation,
    };