[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/myst: Add new mainboard

[Jon Murphy (Code Review)]

Attention is currently required from: Raul Rangel, Martin L Roth, Eric Lai, Martin Roth, Fred Reitberger, Tim Van Patten, Karthik Ramasubramanian, Felix Held, Mark Hasemeyer.

Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74093 )

Change subject: mb/google/myst: Add new mainboard
......................................................................

Patch Set 10:

(4 comments)

File src/mainboard/google/myst/Kconfig:

https://review.coreboot.org/c/coreboot/+/74093/comment/8f38dd25_61fbc2b9 
PS3, Line 8: config AMD_FWM_POSITION_INDEX
           : 	int
           : 	default 3
> Phoenix has a fixed EFS location (0x20000) so this config value has no effect

Done

File src/mainboard/google/myst/chromeos.fmd:

https://review.coreboot.org/c/coreboot/+/74093/comment/cb815f11_bc90629e 
PS2, Line 2: 	SI_BIOS {
> I'd have to check with the ABL team to know why the APOB increased.

Done

File src/mainboard/google/myst/chromeos.fmd:

https://review.coreboot.org/c/coreboot/+/74093/comment/39e6bcba_8b3b18d1 
PS3, Line 36: }
> A 16 MB layout for a first pass should be fine.

Opened b/276944900 and added a TODO in the flashmap descriptor

File src/mainboard/google/myst/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/74093/comment/43ece9e9_441bf63d 
PS2, Line 16: 	Name(LIDS, 0)
> The LIDS object is used by the EC and not by the SoC. […]

Done