[coreboot-gerrit] Change in coreboot[master]: [TEST] Helios: Add fan speed control for TSR3 sensor with DPTF settings

[Mengqi Guo (Code Review)]

Mengqi Guo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41425 )

Change subject: [TEST] Helios: Add fan speed control for TSR3 sensor with DPTF settings
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41425/4/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/41425/4/src/mainboard/google/hatch/... 
PS4, Line 93: 100
> Here these entreies are 90, 80, 60,...,10 are the mapped control points for DFPS.  […]

Thanks everyone for the detailed explanation.

My understanding is fan will kick in at 44C, and fan activity increases as temperature increases. Fan activity hits max when TSR3 hits 50C.

CPU starts to throttle when TSR3 hits 50C.

This way fan activity starts before CPU throttle.

TSR1 also controls fan activity.