Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36463 )
Change subject: soc/intel/{cnl,icl,skl}: Move sleepstates.asl into common/block/acpi ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36463/1/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi/sleepstates.asl:
https://review.coreboot.org/c/coreboot/+/36463/1/src/soc/intel/common/block/... PS1, Line 17: : Name (_S0, Package () { 0x0, 0x0, 0x0, 0x0 }) : Name (_S3, Package () { 0x5, 0x5, 0x0, 0x0 }) : Name (_S4, Package () { 0x6, 0x6, 0x0, 0x0 }) : Name (_S5, Package () { 0x7, 0x7, 0x0, 0x0 })
Those have been the same for a very long time on Intel targets?
yes true, but my problem is that, not very comfortable keeping code changes without testing on real HW. hence limited to latest platforms since SKL. is that reasonable for now ?
I understand that, but in this case it's really identical code and the result should even be identical binaries if build with BUILD_TIMELESS=1.