7 Feb
2019
7 Feb
'19
1:16 a.m.
Vadim Bendebury has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31260 )
Change subject: coreboot: check TPM mode on normal boot ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31260/1/src/security/tpm/tss/vendor/cr50/cr5... File src/security/tpm/tss/vendor/cr50/cr50.h:
https://review.coreboot.org/#/c/31260/1/src/security/tpm/tss/vendor/cr50/cr5... PS1, Line 44: TPM_MODE_LOCKED_ENABLED
I'm still rooting for something like: […]
I have not been following this patch closely, but this should be TPM_ENABLED... as the interface could be either i2c or SPI.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70e012efaf1079d43890e909bc6b5015bef6835a
Gerrit-Change-Number: 31260
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Short keithshort@chromium.org
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Keith Short keithshort@chromium.org
Gerrit-Reviewer: Simon Glass sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Vadim Bendebury vbendeb@chromium.org
Gerrit-Comment-Date: Thu, 07 Feb 2019 01:16:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Joel Kitching kitching@google.com
Gerrit-MessageType: comment