Attention is currently required from: YH Lin, Kevin Chang, Tim Wawrzynczak, Zhuohao Lee. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50872 )
Change subject: mb/google/volteer/var/lindar: Add custom SAR values for Lindar/Lillipup ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
It can be done but in this case the FW_CONFIG field will just be used by Lillipup/Lindar, though. […]
``` 2.FW_CONFIG -- we will need to concern about the extendability. Say, if later on we need to add "global" FW_CONFIG field (due to refactoring or other reasons) we have to watch out not to step on this. ``` This is an example. I think we've included the SAR setting in the boxster design: https://chromium.googlesource.com/chromiumos/config/+/refs/heads/main/test/p... I think it is the good time to adopt this feature to Volteer. The new bit assignment should be allocated globally. ie. put into the program.star. The other volteer project which doesn't use the new bit fields shouldn't refer to the new bit fields and should ignore it.
``` 3. Make use of well-known information -- in this case since only Lillipup support tablet mode it can be used to tell them apart. ``` It seems to me the 'TABLETMODE_ENABLED' is a workaround. If the boxster framework already supported the different table (as i mentioned in above) through the FW_CONFIG, i think we should use it.