[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Use MEM_CH_SEL to initialize MemorySpdPrts

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31262 )

Change subject: soc/intel/cannonlake: Use MEM_CH_SEL to initialize MemorySpdPrts
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31262/2/src/soc/intel/cannonlake/cnl_memcfg_... 
File src/soc/intel/cannonlake/cnl_memcfg_init.c:

https://review.coreboot.org/#/c/31262/2/src/soc/intel/cannonlake/cnl_memcfg_... 
PS2, Line 64: gpio_get(GPP_F2) == 1)
This is not going to be true for all boards using CNL PCH. You will instead have to add a parameter to cnl_mb_cfg indicating single_channel and use that here.