cedarhouse1@comcast.net has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38734 )
Change subject: cpu/x86: Put guard around align for smm_save_state_size
......................................................................
Patch Set 3:
(2 comments)
responeded to Nico Huber's comments.
https://review.coreboot.org/c/coreboot/+/38734/3/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
PS3:
So is this an Intel-only tech? If so, the changes to this file should be […]
Yes, this is intel-only.
I see your point, but the change will involved multiple files (one for each family). I can do that as a part of the solution for the issue below.
https://review.coreboot.org/c/coreboot/+/38734/3/src/cpu/x86/mp_init.c@1056
PS3, Line 1056: * value of 0x400 for this value.
You have to be careful what code you read. smmhandler.S, smmhandler.c, […]
Thanks for the opinion and suggestion.
I've been looking this morning's issue, in particular that >4 processors breaks this. So, your suggestions are helpful.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia584f7e9b86405a12eb6cbedc3a2615a8727f69e
Gerrit-Change-Number: 38734
Gerrit-PatchSet: 3
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Kevin Paul Herbert
kph@meraki.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Feb 2020 22:39:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cedarhouse1@comcast.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment