Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48858 )
Change subject: soc/intel/apollolake: Fix FSP/GOP display init ......................................................................
soc/intel/apollolake: Fix FSP/GOP display init
Configuring the panel power and backlight for an internal display when using FSP/GOP display init causes FSP to turn the backlight off. Fix this by skipping panel init when FSP/GOP display init is used.
Test: build/boot google/ampton with FSP/GOP display init selected, verify backlight enabled and payload display visible
Change-Id: Ifdc3591b714205e864cd1d0db0897d43bd6616a2 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/soc/intel/apollolake/graphics.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/48858/1
diff --git a/src/soc/intel/apollolake/graphics.c b/src/soc/intel/apollolake/graphics.c index 24d4772..24a0620 100644 --- a/src/soc/intel/apollolake/graphics.c +++ b/src/soc/intel/apollolake/graphics.c @@ -62,6 +62,9 @@ if (!conf) return;
+ if (CONFIG(RUN_FSP_GOP)) + return; + mmio_res = probe_resource(dev, PCI_BASE_ADDRESS_0); if (!mmio_res || !mmio_res->base) return;