13 Oct
2020
13 Oct
'20
8:42 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44918 )
Change subject: drivers/intel/usb4: Add driver for USB4 retimer device ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... PS12, Line 39: 0x0F This doesn't match the comment above. Should be 0x7?
https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... PS12, Line 43: 0x03 Doesn't match the comment. Should be 0x1?
--
To view, visit https://review.coreboot.org/c/coreboot/+/44918
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfb85dc3c0885d828aba3855a66109043250ab86
Gerrit-Change-Number: 44918
Gerrit-PatchSet: 12
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Oct 2020 05:42:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment