Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38736 )
Change subject: lib/imd_cbmem.c: Add a helper function to indicate that cbmem is ready
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38736/1/src/include/cbmem.h
File src/include/cbmem.h:
https://review.coreboot.org/c/coreboot/+/38736/1/src/include/cbmem.h@84
PS1, Line 84: /* Returns 1 if cbmem is initialized, 0 otherwise */
It makes a big difference for compile time elimination. If you did something like […]
Thanks for explain and the pointer.
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0231ab9c0b78a69faa762e0a97378bf0b50eebaf
Gerrit-Change-Number: 38736
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Aug 2020 21:42:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment