6 Oct
2019
6 Oct
'19
10:02 a.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )
Change subject: cpu/qemu-x86: Add x86_64 bootblock support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35680/5/src/arch/x86/bootblock_crt0... File src/arch/x86/bootblock_crt0.S:
https://review.coreboot.org/c/coreboot/+/35680/5/src/arch/x86/bootblock_crt0... PS5, Line 51: movd %eax, %mm0 You want to avoid clobbering %eax in entry64.inc.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec92c6cea464c97c18a0811e2e91bc22133ace42
Gerrit-Change-Number: 35680
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Alexandru Gagniuc alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Gerd Hoffmann kraxel@redhat.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 06 Oct 2019 10:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment