[coreboot-gerrit] Change in coreboot[master]: mb/ocp/deltalake: Add ipmi POST start command in romstage

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41605 )

Change subject: mb/ocp/deltalake: Add ipmi POST start command in romstage
......................................................................

mb/ocp/deltalake: Add ipmi POST start command in romstage

Add function to send POST start command to BMC. This function is
used in romstage and the POST end command will be sent in u-root.

TEST=Read POST command log in OpenBMC,
if command received successfully, message may show as below,

root@bmc-oob:~# cat /var/log/messages |grep -i "POST"
 2020 Jul 15 16:36:11 bmc-oob. user.info fby3-v2020.23.1:
ipmid: POST Start Event for Payload#2
root@bmc-oob:~#

Signed-off-by: TimChu 
Change-Id: Ide0e2a52876db555ed8b5e919215e85731fd80ed
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41605
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/mainboard/ocp/deltalake/ipmi.c
M src/mainboard/ocp/deltalake/ipmi.h
M src/mainboard/ocp/deltalake/romstage.c
3 files changed, 28 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/ocp/deltalake/ipmi.c b/src/mainboard/ocp/deltalake/ipmi.c
index acff3db..9c5a0c0 100644
--- a/src/mainboard/ocp/deltalake/ipmi.c
+++ b/src/mainboard/ocp/deltalake/ipmi.c
@@ -75,6 +75,29 @@
    return CB_SUCCESS;
 }

+enum cb_err ipmi_set_post_start(const int port)
+{
+	int ret;
+	struct ipmi_rsp rsp;
+
+	ret = ipmi_kcs_message(port, IPMI_NETFN_OEM, 0x0,
+				 IPMI_BMC_SET_POST_START, NULL, 0, (u8 *) &rsp,
+				 sizeof(rsp));
+
+	if (ret < sizeof(struct ipmi_rsp) || rsp.completion_code) {
+		printk(BIOS_ERR, "IPMI: %s command failed (ret=%d rsp=0x%x)\n",
+		       __func__, ret, rsp.completion_code);
+		return CB_ERR;
+	}
+	if (ret != sizeof(rsp)) {
+		printk(BIOS_ERR, "IPMI: %s response truncated\n", __func__);
+		return CB_ERR;
+	}
+
+	printk(BIOS_DEBUG, "IPMI BMC POST is started\n");
+	return CB_SUCCESS;
+}
+
 void init_frb2_wdt(void)
 {
    char val[VPD_LEN];
diff --git a/src/mainboard/ocp/deltalake/ipmi.h b/src/mainboard/ocp/deltalake/ipmi.h
index 840f999..bb0b4a6 100644
--- a/src/mainboard/ocp/deltalake/ipmi.h
+++ b/src/mainboard/ocp/deltalake/ipmi.h
@@ -9,6 +9,7 @@
 #define   IPMI_OEM_SET_PPIN			0x77
 #define   IPMI_OEM_GET_PCIE_CONFIG		0xf4
 #define   IPMI_OEM_GET_BOARD_ID			0x37
+#define   IPMI_BMC_SET_POST_START		0x73

enum config_type {
    PCIE_CONFIG_UNKNOWN = 0x0,
@@ -28,5 +29,6 @@
 enum cb_err ipmi_set_ppin(struct ppin_req *req);
 enum cb_err ipmi_get_pcie_config(uint8_t *config);
 enum cb_err ipmi_get_slot_id(uint8_t *slot_id);
+enum cb_err ipmi_set_post_start(const int port);
 void init_frb2_wdt(void);
 #endif
diff --git a/src/mainboard/ocp/deltalake/romstage.c b/src/mainboard/ocp/deltalake/romstage.c
index 52679df..b366fd9 100644
--- a/src/mainboard/ocp/deltalake/romstage.c
+++ b/src/mainboard/ocp/deltalake/romstage.c
@@ -117,8 +117,10 @@
 {
    /* Since it's the first IPMI command, it's better to run get BMC
       selftest result first */
-	if (ipmi_kcs_premem_init(CONFIG_BMC_KCS_BASE, 0) == CB_SUCCESS)
+	if (ipmi_kcs_premem_init(CONFIG_BMC_KCS_BASE, 0) == CB_SUCCESS) {
+		ipmi_set_post_start(CONFIG_BMC_KCS_BASE);
    	init_frb2_wdt();
+	}

mainboard_config_gpios(mupd);
    mainboard_config_iio(mupd);