[coreboot-gerrit] Change in coreboot[master]: drivers/gfx: Add generic graphics with SSDT generator

[Mathew King (Code Review)]

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36041 )

Change subject: drivers/gfx: Add generic graphics with SSDT generator
......................................................................

Patch Set 14:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36041/13//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36041/13//COMMIT_MSG@9 
PS13, Line 9: This change a
> Best to use imperative tense...just say: […]

Done

https://review.coreboot.org/c/coreboot/+/36041/13/src/drivers/generic/gfx/gf... 
File src/drivers/generic/gfx/gfx.c:

https://review.coreboot.org/c/coreboot/+/36041/13/src/drivers/generic/gfx/gf... 
PS13, Line 59: privacy_screen_callbacks
> Could this become a structure instead of an array? That would let us name each member.

acpigen_write_dsm takes an array of callbacks