Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )
Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................
Patch Set 5:
(2 comments)
In the future, please make sure that all of your comments are marked as resolved so the patch can be committed.
https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7
PS1, Line 7: Moffet
Using SOC name instead.
Done
https://review.coreboot.org/c/coreboot/+/34687/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34687/2//COMMIT_MSG@2
PS2, Line 2: perezpri
`git commit --amend --author="Bernardo Perez Priego <bernardo.perez.priego@intel. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34687
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d245f1b3f0d0cfec77c31033eb20f147fd3d870
Gerrit-Change-Number: 34687
Gerrit-PatchSet: 5
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 23 Aug 2019 06:36:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment