28 Apr
2020
28 Apr
'20
7:41 p.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39869 )
Change subject: payloads/seabios: Add Hardware IRQ Kconfig ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39869/4/payloads/external/SeaBIOS/K... File payloads/external/SeaBIOS/Kconfig:
https://review.coreboot.org/c/coreboot/+/39869/4/payloads/external/SeaBIOS/K... PS4, Line 60: This option should : be enabled for all platforms/boards except for those which require : it to be disabled.
"If it needs to be disabled, disable it" feels a bit tautological indeed.
better now?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39869
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23e9b30d2d1042c86bd10f134d6fe361edaf8cb2
Gerrit-Change-Number: 39869
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Tue, 28 Apr 2020 17:41:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment