Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45893 )
Change subject: amdfwtool: Fix the gcc warning about sign comparison
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45893/2/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/45893/2/util/amdfwtool/amdfwtool.c@...
PS2, Line 670: uint32_t i;
What is the reason to limit this to 32 bit, and not to take the default length: unsigned int or size_t?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45893
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59624326233284e6c3595df49625563254949c45
Gerrit-Change-Number: 45893
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 03 Oct 2020 09:07:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment