Attention is currently required from: Cliff Huang, Lance Zhao, Tim Wawrzynczak.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82641?usp=email )
Change subject: acpi: add and use defines for LAPIC feature flags ......................................................................
acpi: add and use defines for LAPIC feature flags
Both the processor local APIC structure and the processor local x2APIC structure use the same flag bit definitions. ACPI spec 6.4 was used as a reference.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I8101c2ea874c8b12b130dbe9a0a7e0f0d94adffa --- M src/acpi/acpi_apic.c M src/include/acpi/acpi.h 2 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/82641/1
diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c index 9098811..ebff44f 100644 --- a/src/acpi/acpi_apic.c +++ b/src/acpi/acpi_apic.c @@ -11,7 +11,7 @@ { lapic->type = LOCAL_APIC; /* Local APIC structure */ lapic->length = sizeof(acpi_madt_lapic_t); - lapic->flags = (1 << 0); /* Processor/LAPIC enabled */ + lapic->flags = ACPI_MADT_LAPIC_ENABLED; lapic->processor_id = cpu; lapic->apic_id = apic;
@@ -23,7 +23,7 @@ lapic->type = LOCAL_X2APIC; /* Local APIC structure */ lapic->reserved = 0; lapic->length = sizeof(acpi_madt_lx2apic_t); - lapic->flags = (1 << 0); /* Processor/LAPIC enabled */ + lapic->flags = ACPI_MADT_LAPIC_ENABLED; lapic->processor_id = cpu; lapic->x2apic_id = apic;
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 0e5b4b2..4a71aef 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -726,6 +726,10 @@
#define ACPI_MADT_MAX_LAPIC_ID 0xfe
+/* MADT Local APIC Feature Flags */ +#define ACPI_MADT_LAPIC_ENABLED (1 << 0) +#define ACPI_MADT_LAPIC_ONLINE_CAPABLE (1 << 1) + /* MADT: Local APIC NMI Structure */ typedef struct acpi_madt_lapic_nmi { u8 type; /* Type (4) */