Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37361 )
Change subject: lib/imd_cbmem: Eliminate unnecessary NULL check ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37361/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37361/1//COMMIT_MSG@7 PS1, Line 7: lib/imd_cbmem: &imd_cbmem is never NULL, so remove that path
lib/imd_cbmem: eliminate unnecessary NULL check […]
Done
https://review.coreboot.org/c/coreboot/+/37361/1/src/lib/imd_cbmem.c File src/lib/imd_cbmem.c:
https://review.coreboot.org/c/coreboot/+/37361/1/src/lib/imd_cbmem.c@58 PS1, Line 58: /* These are the different situations to handle:
How would this be handled with this change?
It's all done through cbmem_initialize_id_size setting up IMD near cbmem_top, but to be honest, the code flow isn't that clear to me either. I just know that this doesn't really change behavior (except for reducing stack size) because it always fell back to the code paths I left behind.